Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few grammatical errors #29

Closed
benyamin-noori opened this issue Jul 31, 2017 · 2 comments
Closed

A few grammatical errors #29

benyamin-noori opened this issue Jul 31, 2017 · 2 comments

Comments

@benyamin-noori
Copy link

I noticed there are a few grammatical errors:

In section 4. Lookaround this part:
"which means: get all the numbers which contains . character and preceded by $ character."
Should be modified to:
"which means: get all the numbers which contain. character and are preceded by $ character."

Also, in section 2.5:
"As we discussed before that in regular expression if we put a quantifier after a character than it will repeat the preceding character."
Should be modified to:
"As we discussed before that in regular expression if we put a quantifier after a character then it will repeat the preceding character."

@falaktheoptimist
Copy link
Contributor

Fixed with #27

@priyadhoundiyal
Copy link

Not OP but can we reopen this? I found a few more grammatical errors.
"Imagine you are writing an application and you want to set the rules when user choosing their username. We want the username can contains letter, number, underscore and hyphen."
should be modified to:
"Imagine you are writing an application and you want to set the rules for when a user chooses their username. We want to allow the username to contain letters, numbers, underscore and hyphen."

In section 1, I think "A regular expression is just a pattern of letters and digits" should be replaced with:
"A regular expression is just a pattern of characters" since characters is generic and can be used to represent letters, digits and symbols.

In section 2,
"Some meta characters have a special meaning that are written inside the square brackets"
should be replaced with
"Some meta characters have a special meaning and are written inside square brackets"

In section 2.8
"In regular expressions, to check if the matching symbol is the starting symbol or ending symbol of the input string for this purpose we use anchors" should be replaced by
"In regular expressions, we use anchors to check if the matching symbol is the starting symbol or ending symbol of the input string"

@ziishaned ziishaned reopened this Aug 11, 2017
atefBB pushed a commit to atefBB/learn-regex that referenced this issue Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants