Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / improve RSS handling #2819

Closed
3 of 4 tasks
cmfcmf opened this issue Mar 23, 2016 · 3 comments
Closed
3 of 4 tasks

Fix / improve RSS handling #2819

cmfcmf opened this issue Mar 23, 2016 · 3 comments
Assignees
@cmfcmf
Labels
Bug
Milestone
1.4.2

Comments

@cmfcmf
Copy link
Contributor

cmfcmf commented Mar 23, 2016

Permission issues

Quite some time ago, a new permission rule was added to disallow arbitrary users to change the website's theme.

Maincontent issues

RSS issues

  • The self reference link inside the RSS theme points to / when using an old-style url.
@cmfcmf cmfcmf added the Bug label Mar 23, 2016
@cmfcmf cmfcmf added this to the 1.4.2 milestone Mar 23, 2016
@cmfcmf cmfcmf mentioned this issue Mar 23, 2016
Closed
@cmfcmf cmfcmf self-assigned this Mar 23, 2016
craigh added a commit that referenced this issue Mar 23, 2016
@craigh
Fix output of theme maincontent to NOT automatically include a unique…
6b8b7fb 
… div wrapper. Move wrapper to AbstractTheme.

| Q                 | A
| ----------------- | ---
| Bug fix?          | no
| New feature?      | no
| BC breaks?        | no
| Deprecations?     | no
| Fixed tickets     | -
| Refs tickets      | #2819
| License           | MIT
| Changelog updated | no
@craigh craigh mentioned this issue Mar 23, 2016
Merged
@craigh
Copy link
Member

craigh commented Mar 23, 2016

In core-2.0 a different method will be used to change themes. the module will need to provide their own method and 'annotate' it with @Theme('ZikulaRssTheme') (or similar)

@craigh
Copy link
Member

craigh commented Mar 24, 2016

refs #1776

@cmfcmf cmfcmf mentioned this issue Mar 25, 2016
Merged
5 tasks
@craigh
Copy link
Member

craigh commented Mar 27, 2016

closed by #2826

@craigh craigh closed this as completed Mar 27, 2016
Guite added a commit that referenced this issue Apr 25, 2016
@Guite
refactored pagelock module to 2.0 style (#2862)
18d2746 
* refactored pagelock module to 2.0 style

* typo

* added missing service argument

* several improvements

* minor fixes

* several amendments

* rename method

* typo

* minor fix for composer.json

* minor docblock fix

* minor amendments

* minor cleanup regarding Multisites

* Fixed StyleCI issue

* update composer.lock updates

 - paragonie/random_compat (v1.2.2 => v1.4.1)
 - ezyang/htmlpurifier dev-master (92aabf2 => 25db9e1)
 - abeautifulsite/jquery-minicolors dev-master (8039c59 => 543116f)

* Rename setasdefault.html.twig to setAsDefault.html.twig

* Rename viewmodulelist.html.twig to viewModuleList.html.twig

* Rename moduleservices.html.twig to moduleServices.html.twig

* Revert changes in admin api

* updated clickjacking protection listener

* use array shorthand syntax, added some missing docblocks

* fixed regression

* correct string translation. refs zikula-modules/MediaModule#64

* use non-aliased service name. refs #2808 @Guite

* use array shorthand syntax, added some missing docblocks (reverted from commit 93f6a61)

* corrected method call of variable api, fixed #2812

* disable dependency check for vendors in modules.

* disable dependency check for vendors in modules.

* Don't use PHP_VERSION constant

* Removed {break} Smarty tag

* Fix output of theme maincontent to NOT automatically include a unique div wrapper. Move wrapper to AbstractTheme.

| Q                 | A
| ----------------- | ---
| Bug fix?          | no
| New feature?      | no
| BC breaks?        | no
| Deprecations?     | no
| Fixed tickets     | -
| Refs tickets      | #2819
| License           | MIT
| Changelog updated | no

* Added issue and pull request tempaltes, closes #2778.

* update composer.json to include robloach/component-install as an explicit dependency. update composer.lock

* update method for php strict standards

* Remove dev-master for two dependencies.

* Added Vagrant support.

* correct typehint in ZikulaPhpFileExtractor

* | Q                 | A
| ----------------- | ---
| Bug fix?          | no
| New feature?      | no
| BC breaks?        | no
| Deprecations?     | no
| Tests pass?       | yes
| Fixed tickets     | #2823
| Refs tickets      | -
| License           | MIT
| Doc PR            | -
| Changelog updated | no

* minor correction to Categories Form Type

* correct display of developer notice in Admin panel for new admin header. fixes #2828

* grduingly provide backward compatible installer for 'transition' modules. fixes #2831

* Make Bootstrap theme site default.

| Q                 | A
| ----------------- | ---
| Bug fix?          | yes
| New feature?      | yes
| BC breaks?        | no
| Deprecations?     | no
| Fixed tickets     | -
| Refs tickets      | -
| License           | MIT
| Changelog updated | yes

## Description
Make Bootstrap theme site default (new features added, blocks and permissions adjusted specific to theme). Improved compatibility of zikula-specific bootstrap overrides with respect to navbars. Provide method for customizing Bootstrap path in Core-2.0 themes

## Todos
- [x] Tests
- [x] Documentation
- [x] Changelog

* update composer.lock

* Create Theme permission at installation.
Include selected theme in permission check.

* update composer.lock cc/ @Guite

* Updated Symfony version

* update Core version to 1.4.3

* update changelog for 1.4.3

* refactor Settings module to Core-2.0 spec.

| Q                 | A
| ----------------- | ---
| Bug fix?          | no
| New feature?      | no
| BC breaks?        | no
| Deprecations?     | no
| Fixed tickets     | -
| Refs tickets      | #2034, #1753
| License           | MIT
| Changelog updated | yes

* additional features to bootstrap topnav login button to allow improved access to user-related functions.

* minor css fix to bootstrap theme topnav login block

* update composer.lock

  - Removing nikic/php-parser (v1.4.1)
  - Installing nikic/php-parser (v2.0.1)

  - Removing jms/translation-bundle (1.2.1)
  - Installing jms/translation-bundle (1.2.2)

  - Removing monolog/monolog (1.18.1)
  - Installing monolog/monolog (1.18.2)

  - Updating ezyang/htmlpurifier dev-master (096064d => 2e15d7a)
    Checking out 2e15d7a4dadb08ccdac3f060dcf81112e607b6c4

* fix error on creation of new ExtendedMenublock

* fix StyleCi error

* update composer.lock. force 1.4 branch of php-parser

  - Removing composer/installers (v1.0.23)
  - Installing composer/installers (v1.0.24)

  - Removing nikic/php-parser (v2.0.1)
  - Installing nikic/php-parser (v1.4.1)

* Form improvements (#2846)

* update form extensions to Sy2.8 and add a few features @Guite 😄

* update changelog

* support multiple help elements (#2847)

* support multiple help elements

* Check for empty help values

* Adjust form theme template to use macros to avoid duplicate code. Add alert text feature. @Guite

* Added information about using help arrays

* correct upgrade of 'hybrid' 1.4/2.0 modules

* allow alerts on checkboxes also.

* refactored pagelock module to 2.0 style

* typo

* added missing service argument

* several improvements

* minor fixes

* several amendments

* rename method

* typo

* minor fix for composer.json

* minor docblock fix

* minor amendments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmfcmf cmfcmf

Labels
Bug
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
2 participants
@craigh @cmfcmf