Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not release without compatible versions of Profile and Legal #985

Closed
2 tasks
craigh opened this issue Aug 21, 2013 · 8 comments
Closed
2 tasks

Do not release without compatible versions of Profile and Legal #985

craigh opened this issue Aug 21, 2013 · 8 comments
Labels
Milestone

Comments

@craigh
Copy link
Member

craigh commented Aug 21, 2013

Do not release without compatible & fully functional versions of Profile and Legal modules (as of this ticket Profile is not functional)

  • Check (and update) Legale
  • Check (and update) Profile
@craigh
Copy link
Member Author

craigh commented Nov 2, 2013

@Drak - maybe you could spend some time converting Legal and Profile to the new module standard?

@ghost
Copy link

ghost commented Nov 2, 2013

Core isn't really ready for module conversion and I have a lot more to do
with themes and twig which is really taxing my already limited skills.
Until I get a grip on that I really can't focus on anything else.

@craigh
Copy link
Member Author

craigh commented Nov 2, 2013

What do mean the core isn't ready for module conversion? all the /system modules are converted ... And dizkus...

Sent from my iPhone

On Nov 2, 2013, at 8:10 AM, Drak notifications@github.com wrote:

Core isn't really ready for module conversion and I have a lot more to do
with themes and twig which is really taxing my already limited skills.
Until I get a grip on that I really can't focus on anything else.

Reply to this email directly or view it on GitHub.

@ghost
Copy link

ghost commented Nov 2, 2013

These can still only be thought of as POC. There's a lot more to do but
what is not clear until I can finish the other tasks. There is no harm in
converting legal etc now, but it's not a priority for me and I am sure
there will be extra details. For one, I am sure we can combine version and
bundle classes together,but it's not clear yet. I know that is a small
detail, but my time is better spend on core until it's finished. We won't
know what is finished until we have fully weaved in symfony and have fully
symfony examples in the core. Do you see the point?

@ghost
Copy link

ghost commented Nov 2, 2013

I'd like to close this ticket because it goes without saying, during the build there QA will not pass if these modules do not work. There is no need for a ticket here.

@ghost ghost closed this as completed Nov 2, 2013
@craigh
Copy link
Member Author

craigh commented Nov 2, 2013

These can still only be thought of as POC. There's a lot more to...

:sadface: I was hoping all the refactoring was complete ...

@ghost
Copy link

ghost commented Nov 2, 2013

Look at the PR I have - that is much more how a module will look.

@rojblake
Copy link
Contributor

rojblake commented Nov 2, 2013

I've just about finished the legal module to the same standard as the current core modules i.e. no twig. I'll start on profile after in finished with legal.

-Mark

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants