-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more Doctrine related container settings in the appropriate CompilerPass #1854
Conversation
please test this with installation of modules that use extensions like Tag and Dizkus |
Sure, that's what I already did and what I'm planning to do 😏 |
thanks 👍 |
Is a compiler pass the right place for this? |
Not yet, I will do so soon. |
ping @cmfcmf |
ping @cmfcmf |
ping @Drak - if you have concerns please further elaborate. if not, let's merge this then. |
Move more Doctrine related container settings in the appropriate CompilerPass
This also makes sure they are loaded even if the core is not instantiated (e.g. when using the Symfony console).