Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block advanced placement options #516

Merged
2 commits merged into from
Oct 6, 2012
Merged

Block advanced placement options #516

2 commits merged into from
Oct 6, 2012

Conversation

lmm-git
Copy link

@lmm-git lmm-git commented Oct 6, 2012

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Tests pass: yes
Fixes tickets: #516
References:
License of the code: LGPLv3+
Documentation PR:
Todo:

The blocks wasn't shown if I type as module users instead of Users with a capital letter if the block should be shown only in the users module. The problem was that the module naming, type naming and function naming in Zikula isn't case sensitive but the module checked this case-sensitive.

a capital letter if the block should be shown only in the users module.
The problem is that the module naming, type naming and function naming
in Zikula isn't case sensitive.
@ghost
Copy link

ghost commented Oct 6, 2012

Thanks for the fix but please add a changelog entry in src/docs/CHANGELOG and use the PR body template in CONTRIBUTING.md

ghost pushed a commit that referenced this pull request Oct 6, 2012
Block advanced placement options fixes #516
@ghost ghost merged commit 6c545a1 into zikula:release-1.3 Oct 6, 2012
@lmm-git
Copy link
Author

lmm-git commented Mar 9, 2013

same problem like #518. It's the old version in the 1.3 branch

ghost pushed a commit that referenced this pull request Feb 12, 2014
This PR was merged into zikula:release-1.3 branch.

Discussion
----------

adding my 1.3.6patch repro

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | 
| Refs tickets  | 
| License       | MIT
| Doc PR        | 

this will close my collection at https://github.com/rallek/1.3.6patch

Commits
-------

be16503 workflow fix

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| Refs tickets  | #704
| License       | MIT
| Doc PR        | rallek
3d081c9 drag and drop fix for extmenu

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| Refs tickets  | #924
| License       | MIT
| Doc PR        |

see also https://gist.github.com/cmfcmf/6329308 rallek
6715748 Fixed Block filtering in 1.3.5/6

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| Refs tickets  | #516, #938
| License       | MIT
| Doc PR        | rallek
2ca1a5b Fixed displaying of selection boxes

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #762
| Refs tickets  | #775
| License       | MIT
| Doc PR        | rallek
64f0cd8 added jpeg

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| Refs tickets  | #783
| License       | MIT
| Doc PR        | rallek
a2b3e3a Avoid flush by category selector

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| Refs tickets  | #1561
| License       | MIT
| Doc PR        | rallek
dd0036b some more fixes

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| Refs tickets  |
| License       | MIT
| Doc PR        |

do not know the tickets of this fixes rallek
2f519ce Update users_user_login.tpl

``|safetext`` added rallek
966e29b Update users_block_login.tpl

``|safetext`` added rallek
b05529e Update CategorySelector.php

``public `` added
thanks to cmf! rallek
20383d0 Update PageUtil.php

Korinthen for cmf ;-) rallek
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant