Added jpeg to allowed extensions i userdata directory #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this apply to any other folders? |
|
This is a minimum for userdata, also need for images folder, but in images folder I'm not seeing .htaccess file. In modules folder I think it is not so important, because developer can skip to use jpeg extension. To be more consistent, if you like, I can place jpeg in all other .htaccess files with jpg in them. |
|
Yes, please be thorough. |
| @@ -3,7 +3,7 @@ | |||
| # stored under the userdata/ directory | |||
| # ---------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Let's get rid of these needless comments too.
ghost
pushed a commit
that referenced
this pull request
Mar 21, 2013
Added jpeg to allowed extensions i userdata directory
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Feb 12, 2014
This PR was merged into zikula:release-1.3 branch. Discussion ---------- adding my 1.3.6patch repro | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | | License | MIT | Doc PR | this will close my collection at https://github.com/rallek/1.3.6patch Commits ------- be16503 workflow fix | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #704 | License | MIT | Doc PR | rallek 3d081c9 drag and drop fix for extmenu | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #924 | License | MIT | Doc PR | see also https://gist.github.com/cmfcmf/6329308 rallek 6715748 Fixed Block filtering in 1.3.5/6 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #516, #938 | License | MIT | Doc PR | rallek 2ca1a5b Fixed displaying of selection boxes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #762 | Refs tickets | #775 | License | MIT | Doc PR | rallek 64f0cd8 added jpeg | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #783 | License | MIT | Doc PR | rallek a2b3e3a Avoid flush by category selector | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #1561 | License | MIT | Doc PR | rallek dd0036b some more fixes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | | License | MIT | Doc PR | do not know the tickets of this fixes rallek 2f519ce Update users_user_login.tpl ``|safetext`` added rallek 966e29b Update users_block_login.tpl ``|safetext`` added rallek b05529e Update CategorySelector.php ``public `` added thanks to cmf! rallek 20383d0 Update PageUtil.php Korinthen for cmf ;-) rallek
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in .htaccess file jpeg extension.
It seems silly, but can save some time for one who can't see some of uploaded images.