adding my 1.3.6patch repro #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #704 | License | MIT | Doc PR |
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #924 | License | MIT | Doc PR | see also https://gist.github.com/cmfcmf/6329308
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #783 | License | MIT | Doc PR |
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #1561 | License | MIT | Doc PR |
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | | License | MIT | Doc PR | do not know the tickets of this fixes
|
This looks far better! 🎉 ⭐ 💯 |
|
:) |
| @@ -18,7 +18,7 @@ | |||
| </div> | |||
| <form id="users_loginblock_login_form" class="z-form z-linear{if !$show_login_form} z-hide{/if}" action="{modurl modname="Users" type="user" func="login"}" method="post"> | |||
| <div> | |||
| <input type="hidden" id="users_loginblock_returnpage" name="returnpage" value="{$returnpage|safetext}" /> | |||
| <input type="hidden" id="users_loginblock_returnpage" name="returnpage" value="{$returnpage}" /> | |||
There was a problem hiding this comment.
This and the change in the following file however will have to be reverted.
There was a problem hiding this comment.
help needed. No idea what to do and what you mean
``|safetext`` added
``|safetext`` added
``public `` added thanks to cmf!
Korinthen for cmf ;-)
|
@rallek good work but next time create a topic branch or your PRs can get screwed up after you submit them. |
|
PR need the header in the description as per CONTRIBUTING in repo. |
|
added the header. Details I added always at each commit |
ghost
pushed a commit
that referenced
this pull request
Feb 12, 2014
This PR was merged into zikula:release-1.3 branch. Discussion ---------- adding my 1.3.6patch repro | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | | License | MIT | Doc PR | this will close my collection at https://github.com/rallek/1.3.6patch Commits ------- be16503 workflow fix | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #704 | License | MIT | Doc PR | rallek 3d081c9 drag and drop fix for extmenu | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #924 | License | MIT | Doc PR | see also https://gist.github.com/cmfcmf/6329308 rallek 6715748 Fixed Block filtering in 1.3.5/6 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #516, #938 | License | MIT | Doc PR | rallek 2ca1a5b Fixed displaying of selection boxes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #762 | Refs tickets | #775 | License | MIT | Doc PR | rallek 64f0cd8 added jpeg | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #783 | License | MIT | Doc PR | rallek a2b3e3a Avoid flush by category selector | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | #1561 | License | MIT | Doc PR | rallek dd0036b some more fixes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | Refs tickets | | License | MIT | Doc PR | do not know the tickets of this fixes rallek 2f519ce Update users_user_login.tpl ``|safetext`` added rallek 966e29b Update users_block_login.tpl ``|safetext`` added rallek b05529e Update CategorySelector.php ``public `` added thanks to cmf! rallek 20383d0 Update PageUtil.php Korinthen for cmf ;-) rallek
ghost
merged commit 
|
👍 Thanks a lot Ralf for collecting and caring ;-) |
|
@rallek - can you please make sure that any fixes included here are also fixed in the |
|
The merge policy should only be to back-port from |
|
My PR was only backport from 1.3. Nothing to do for 1.3 from my side. I am not able to do programming for the core at all :-) My PR was reviewed by cmf. Thanks for helping! |
|
I also think it's only backports from 1.3, there is nothing new here. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will close my collection at https://github.com/rallek/1.3.6patch