Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LangChainLLMs with LLM #170

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

shiyu22
Copy link
Contributor

@shiyu22 shiyu22 commented Apr 11, 2023

No description provided.

@SimFG
Copy link
Collaborator

SimFG commented Apr 11, 2023

The examples using the LangChainLLMs class should also need to be modified accordingly.

# before
langchain_openai = OpenAI(model_name='text-ada-001')
llm = LangChainLLMs(langchain_openai)

# now
langchain_openai = OpenAI(model_name='text-ada-001')
llm = LangChainLLMs(llm=langchain_openai)

please check it

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>
@shiyu22
Copy link
Contributor Author

shiyu22 commented Apr 11, 2023

The examples using the LangChainLLMs class should also need to be modified accordingly.

# before
langchain_openai = OpenAI(model_name='text-ada-001')
llm = LangChainLLMs(langchain_openai)

# now
langchain_openai = OpenAI(model_name='text-ada-001')
llm = LangChainLLMs(llm=langchain_openai)

please check it

Done

@SimFG
Copy link
Collaborator

SimFG commented Apr 11, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shiyu22, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 598951c into zilliztech:dev Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants