Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar return emb in ndarray #218

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

junjiejiangjjj
Copy link
Contributor

No description provided.

Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #218 (b2eb5ba) into dev (112aae9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #218      +/-   ##
==========================================
+ Coverage   92.55%   92.65%   +0.10%     
==========================================
  Files          47       48       +1     
  Lines        1504     1511       +7     
==========================================
+ Hits         1392     1400       +8     
+ Misses        112      111       -1     
Impacted Files Coverage Δ
gptcache/manager/scalar_data/sql_storage.py 96.29% <100.00%> (+0.03%) ⬆️

... and 8 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 17, 2023
@SimFG
Copy link
Collaborator

SimFG commented Apr 17, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junjiejiangjjj, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fd618bb into zilliztech:dev Apr 17, 2023
SimFG pushed a commit that referenced this pull request Apr 17, 2023
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
@junjiejiangjjj junjiejiangjjj deleted the bytes2emb branch April 17, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants