Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the position of lint comment #466

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Improve the position of lint comment #466

merged 1 commit into from
Jul 4, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Jul 4, 2023

No description provided.

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #466 (596beda) into dev (24bb5a1) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #466   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          93       93           
  Lines        3735     3735           
=======================================
  Hits         3514     3514           
  Misses        221      221           
Impacted Files Coverage Δ
gptcache/manager/scalar_data/base.py 87.91% <100.00%> (ø)
gptcache/manager/scalar_data/mongo.py 94.40% <100.00%> (ø)
gptcache/manager/scalar_data/redis_storage.py 97.29% <100.00%> (ø)
gptcache/manager/scalar_data/sql_storage.py 99.37% <100.00%> (ø)

@mergify mergify bot added the ci-passed label Jul 4, 2023
@SimFG SimFG merged commit 6ee5822 into zilliztech:dev Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants