Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Failed to import gptcache due to missing redis dependency #522

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

a9raag
Copy link
Contributor

@a9raag a9raag commented Aug 24, 2023

resolves #521

Moved RedisCacheEviction to its own module to avoid calls that tries to import and install redis

…edis` call

Signed-off-by: Anurag Wagh <a9raag@gmail.com>
Signed-off-by: Anurag Wagh <a9raag@gmail.com>
Signed-off-by: Anurag Wagh <a9raag@gmail.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #522 (09bda62) into dev (790e9f4) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #522   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files          95       96    +1     
  Lines        4014     4017    +3     
=======================================
+ Hits         3769     3772    +3     
  Misses        245      245           
Files Changed Coverage Δ
gptcache/manager/eviction/distributed_cache.py 87.50% <ø> (-2.16%) ⬇️
gptcache/manager/eviction/redis_eviction.py 91.89% <91.89%> (ø)
gptcache/manager/eviction/manager.py 100.00% <100.00%> (ø)

@mergify mergify bot added the ci-passed label Aug 24, 2023
@a9raag
Copy link
Contributor Author

a9raag commented Aug 24, 2023

/assign @SimFG

@SimFG
Copy link
Collaborator

SimFG commented Aug 26, 2023

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a9raag, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f9456aa into zilliztech:dev Aug 26, 2023
7 checks passed
@marioplumbarius
Copy link

I still see the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants