Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2] Add logs for DiskANN build #260

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[2.2] Add logs for DiskANN build #260

merged 1 commit into from
Dec 5, 2023

Conversation

PwzXxm
Copy link
Collaborator

@PwzXxm PwzXxm commented Dec 5, 2023

issue: #259

@PwzXxm
Add logs for DiskAnn Build
ea33468 
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PwzXxm PwzXxm changed the title enhance: [2.2] Add logs for DiskAnn Build enhance: [2.2] Add logs for DiskANN build Dec 5, 2023
@mergify mergify bot added the dco-passed label Dec 5, 2023
@mergify Mergify
Copy link

mergify bot commented Dec 5, 2023

@PwzXxm 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@PwzXxm
Copy link
Collaborator Author

PwzXxm commented Dec 5, 2023

/kind improvement

@PwzXxm PwzXxm changed the title enhance: [2.2] Add logs for DiskANN build [2.2] Add logs for DiskANN build Dec 5, 2023
@liliu-z
Copy link
Collaborator

liliu-z commented Dec 5, 2023

/lgtm

@mergify mergify bot added the ci-passed label Dec 5, 2023
@sre-ci-robot sre-ci-robot merged commit cc4935a into zilliztech:2.2 Dec 5, 2023
9 checks passed
PwzXxm added a commit to PwzXxm/knowhere that referenced this pull request Dec 6, 2023
@PwzXxm
Add logs for DiskAnn Build (zilliztech#260)
ec3d7b4 
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit cc4935a)
This was referenced Dec 6, 2023
Closed
Merged
PwzXxm added a commit to PwzXxm/knowhere that referenced this pull request Dec 6, 2023
@PwzXxm
Add logs for DiskAnn Build (zilliztech#260) Fix concurrent log in Dis…
53f2fdb 
…kAnn build (zilliztech#262)

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit cc4935a)
sre-ci-robot pushed a commit that referenced this pull request Dec 6, 2023
@PwzXxm
Add logs for DiskAnn Build (#260) Fix concurrent log in DiskAnn build (…
868926e 
…#262) (#265)

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit cc4935a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqy123456 cqy123456 Awaiting requested review from cqy123456

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@liliu-z liliu-z

Labels
approved ci-passed dco-passed kind/improvement lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PwzXxm @sre-ci-robot @liliu-z