-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Size interface for binaryset #586
Conversation
Welcome @chyezh! It looks like this is your first PR to zilliztech/knowhere 🎉 |
Signed-off-by: chyezh <chyezh@outlook.com>
765f8e8
to
bd7f0db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=========================================
+ Coverage 0 70.29% +70.29%
=========================================
Files 0 67 +67
Lines 0 4720 +4720
=========================================
+ Hits 0 3318 +3318
- Misses 0 1402 +1402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
=========================================
+ Coverage 0 70.29% +70.29%
=========================================
Files 0 67 +67
Lines 0 4720 +4720
=========================================
+ Hits 0 3318 +3318
- Misses 0 1402 +1402 |
/kind improvement
issue: #585