Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Size interface for binaryset #586

Merged
merged 1 commit into from
May 24, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented May 23, 2024

/kind improvement
issue: #585

@sre-ci-robot
Copy link
Collaborator

Welcome @chyezh! It looks like this is your first PR to zilliztech/knowhere 🎉

Signed-off-by: chyezh <chyezh@outlook.com>
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (3c46f4c) to head (bd7f0db).
Report is 61 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #586       +/-   ##
=========================================
+ Coverage      0   70.29%   +70.29%     
=========================================
  Files         0       67       +67     
  Lines         0     4720     +4720     
=========================================
+ Hits          0     3318     +3318     
- Misses        0     1402     +1402     

see 67 files with indirect coverage changes

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (3c46f4c) to head (bd7f0db).
Report is 62 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #586       +/-   ##
=========================================
+ Coverage      0   70.29%   +70.29%     
=========================================
  Files         0       67       +67     
  Lines         0     4720     +4720     
=========================================
+ Hits          0     3318     +3318     
- Misses        0     1402     +1402     

see 67 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 24, 2024
@sre-ci-robot sre-ci-robot merged commit b926aa1 into zilliztech:main May 24, 2024
12 of 14 checks passed
@chyezh chyezh deleted the knowhere_dev_chyezh branch May 24, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants