Clean build warnings #657
Clean build warnings #657
Conversation
|
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
/kind improvement |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=========================================
+ Coverage 0 71.40% +71.40%
=========================================
Files 0 69 +69
Lines 0 4728 +4728
=========================================
+ Hits 0 3376 +3376
- Misses 0 1352 +1352 |
cydrain
force-pushed
the
caiyd_clean_build_warning
branch
from
e2909b5
to
18ba8e7
Compare
thirdparty/hnswlib/hnswlib/hnswalg.h
Outdated
| @@ -1392,7 +1392,7 @@ class HierarchicalNSW : public AlgorithmInterface<dist_t> { | |||
| } | |||
|
|
|||
| std::unique_ptr<int8_t[]> query_data_sq; | |||
| const data_t* raw_data = (const data_t*)query_data; | |||
| [[gnu::unused]] const data_t* raw_data = (const data_t*)query_data; | |||
There was a problem hiding this comment.
[[maybe_unused]]? Why use gnu directives? Clang may fail
There was a problem hiding this comment.
change to [[maybe_unused]]
|
/hold |
cydrain
force-pushed
the
caiyd_clean_build_warning
branch
from
18ba8e7
to
ea11a38
Compare
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
cydrain
force-pushed
the
caiyd_clean_build_warning
branch
from
ea11a38
to
de2f8a4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain, PwzXxm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Issue: #443