propagate faiss changes from (24 Jun 2024) #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderguzhva
force-pushed
the
merge_faiss_changes_4c
branch
from
fb8094d
to
d9e0ade
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=========================================
+ Coverage 0 71.51% +71.51%
=========================================
Files 0 69 +69
Lines 0 4718 +4718
=========================================
+ Hits 0 3374 +3374
- Misses 0 1344 +1344 |
This was referenced Jun 24, 2024
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
alexanderguzhva
force-pushed
the
merge_faiss_changes_4c
branch
from
d9e0ade
to
a413963
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xxxlzhxxx
pushed a commit
to xxxlzhxxx/knowhere
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate changes from the Faiss baseline (up to Jun 24 2024)
/kind improvement