Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resume a stopped instance when enable hpa #119

Merged
merged 1 commit into from
May 24, 2024

Conversation

haorenfsa
Copy link
Collaborator

/cc @samhuang-z @LoveEachDay

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haorenfsa haorenfsa changed the title Fix resume a stopped instance when enable hpa WIP: Fix resume a stopped instance when enable hpa May 22, 2024
@yellow-shine
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Collaborator

@samhuang-z: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.23%. Comparing base (c9d72b3) to head (25554bd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   82.22%   82.23%   +0.01%     
==========================================
  Files          54       54              
  Lines        4934     4937       +3     
==========================================
+ Hits         4057     4060       +3     
  Misses        693      693              
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haorenfsa haorenfsa changed the title WIP: Fix resume a stopped instance when enable hpa Fix resume a stopped instance when enable hpa May 24, 2024
@haorenfsa haorenfsa merged commit cbe3673 into zilliztech:main May 24, 2024
13 of 14 checks passed
@haorenfsa haorenfsa deleted the hpa branch May 24, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants