Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some values in chart not implemented #130

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

haorenfsa
Copy link
Collaborator

Fix #104
/cc @zwd1208

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (229085b) to head (b896389).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files          54       54           
  Lines        4944     4944           
=======================================
  Hits         4067     4067           
  Misses        693      693           
  Partials      184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm looks good to merge label Jun 12, 2024
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LoveEachDay,haorenfsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
@LoveEachDay
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm looks good to merge label Jun 12, 2024
@sre-ci-robot sre-ci-robot merged commit cb79b48 into zilliztech:main Jun 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

milvus-operator deployment does not support imagePullSecrets
3 participants