Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating pull requests to rjeczalik #4

Closed
imsodin opened this issue Aug 4, 2016 · 1 comment
Closed

Creating pull requests to rjeczalik #4

imsodin opened this issue Aug 4, 2016 · 1 comment

Comments

@imsodin
Copy link
Collaborator

imsodin commented Aug 4, 2016

There was just some PR activity over on rjeczalik repo, so there is activity. I would like to create a PR for the changes introduced in #2 and also a work-in-progress PR for #3.
It makes sense that this PRs come from the Zillode fork and not mine. Now this is the first time I have push access to a git repo, so I wanted to ask first: Is it ok if I create the necessary branches and issue the PRs?
@Zillode
Copy link
Owner

Zillode commented Sep 25, 2016

Certainly,

@imsodin imsodin closed this as completed Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zillode @imsodin