Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request match by body (#12) #108

Merged
merged 7 commits into from
Mar 17, 2024
Merged

feat: request match by body (#12) #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e5a509
refactor(#zimic): keep intuitive test order
diego-aquino Mar 16, 2024
d34e0e9
feat(#zimic): support restricting trackers by body
diego-aquino Mar 16, 2024
bd78254
refactor(#zimic)!: simplify request and response body schemas
diego-aquino Mar 16, 2024
6ca8ab0
test(#zimic): verify interceptors with body restrictions
diego-aquino Mar 16, 2024
1514b5d
test(#zimic): improve http method test scenarios
diego-aquino Mar 16, 2024
1c15ee7
test(zimic-test-client): verify body restrictions
diego-aquino Mar 16, 2024
9cbf53e
test(#zimic): fallback crypto in node 18
diego-aquino Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions apps/zimic-test-client/tests/v0/interceptor/exports/exports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,18 @@ describe('Exports', () => {
expectTypeOf<HttpInterceptorResponseSchemaStatusCode<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorMethodSchema>().not.toBeAny();
expectTypeOf<HttpInterceptorPathSchema>().not.toBeAny();

expectTypeOf<HttpInterceptorSchema>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Root<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Path<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Method<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Request<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Response<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.ResponseByStatusCode<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Headers<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.SearchParams<never>>().not.toBeAny();
expectTypeOf<HttpInterceptorSchema.Body<never>>().not.toBeAny();

expectTypeOf<HttpInterceptorSchemaMethod<never>>().not.toBeAny();
expectTypeOf<LiteralHttpInterceptorSchemaPath<never, never>>().not.toBeAny();
expectTypeOf<NonLiteralHttpInterceptorSchemaPath<never, never>>().not.toBeAny();
Expand Down
27 changes: 19 additions & 8 deletions apps/zimic-test-client/tests/v0/interceptor/thirdParty/shared/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ function declareDefaultClientTests(options: ClientTestDeclarationOptions) {
.post('/users')
.with({
headers: { 'content-type': 'application/json' },
body: creationPayload,
})
.respond((request) => {
expect(request.headers.get('content-type')).toBe('application/json');
Expand Down Expand Up @@ -280,10 +281,15 @@ function declareDefaultClientTests(options: ClientTestDeclarationOptions) {
code: 'validation_error',
message: 'Invalid payload',
};
const creationTracker = authInterceptor.post('/users').respond({
status: 400,
body: validationError,
});
const creationTracker = authInterceptor
.post('/users')
.with({
body: invalidPayload,
})
.respond({
status: 400,
body: validationError,
});

const response = await createUser(invalidPayload);
expect(response.status).toBe(400);
Expand Down Expand Up @@ -318,10 +324,15 @@ function declareDefaultClientTests(options: ClientTestDeclarationOptions) {
code: 'conflict',
message: 'User already exists',
};
const creationTracker = authInterceptor.post('/users').respond({
status: 409,
body: conflictError,
});
const creationTracker = authInterceptor
.post('/users')
.with({
body: conflictingPayload,
})
.respond({
status: 409,
body: conflictError,
});

const response = await createUser(conflictingPayload);
expect(response.status).toBe(409);
Expand Down
6 changes: 3 additions & 3 deletions packages/zimic/src/interceptor/http/interceptor/__tests__/shared/interceptorTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function declareSharedHttpInterceptorTests(options: SharedHttpInterceptor
});

describe('Methods', () => {
const methodTestFactories: Record<HttpInterceptorMethod, () => void> = {
const methodTestFactories: Record<HttpInterceptorMethod, () => Promise<void> | void> = {
GET: declareGetHttpInterceptorTests.bind(null, options),
POST: declarePostHttpInterceptorTests.bind(null, options),
PUT: declarePutHttpInterceptorTests.bind(null, options),
Expand All @@ -38,8 +38,8 @@ export function declareSharedHttpInterceptorTests(options: SharedHttpInterceptor
};

for (const [method, methodTestFactory] of Object.entries(methodTestFactories)) {
describe(method, () => {
methodTestFactory();
describe(method, async () => {
await methodTestFactory();
});
}
});
Expand Down
Loading
Loading