Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead links in CONTRIBUTING.md #44

Closed
ghost opened this issue Mar 25, 2020 · 6 comments
Closed

Dead links in CONTRIBUTING.md #44

ghost opened this issue Mar 25, 2020 · 6 comments
Assignees
@zspencer
Labels
documentation Work that is intended to focus on improving documentation enhancement New feature or request
Projects
Compensated WIP

Comments

@ghost
Copy link

ghost commented Mar 25, 2020

CONTRIBUTING.md is really well written so far, but there are a couple dead links leading to design/README.md and design/ARCHITECTURE.md.
@drllau
Copy link
Contributor

drllau commented Mar 26, 2020 •
edited

+1 @lanegrant (welcome to Zinc Coop), appreciate the reminder as Zee and I were having some access issues trying to merge including trying to upload some files. @zspencer if you can assign this to me I'll fix up the linkrot before it gets worse. We really also need to get a sandbox working so can test out some working examples (just payment + reversecharge until no money, then reset).

@drllau drllau mentioned this issue Mar 26, 2020
Closed
@zspencer zspencer mentioned this issue Mar 26, 2020
Open
@zspencer
Copy link
Member

zspencer commented Mar 26, 2020 •
edited

Thank you @lanegrant - I intend to sprout a docs/ folder today and place the contents I was planning to put in design/README.md and design/ARCHITECTURE.md in there so that our documentation lives both in-repo and on the web..

@drllau - great point re: sandbox. Made a ticket - #45

I'm not entirely sure I'm comfortable handing off the design and architecture documentation just yet; because there's a lot of things that I've learned over the last two years that I need to put into them; but I'll 100% tag you to review the patch I'm going to make today with the documentation!

@zspencer zspencer self-assigned this Mar 26, 2020
@zspencer zspencer added documentation Work that is intended to focus on improving documentation enhancement New feature or request labels Mar 26, 2020
@zspencer zspencer added this to To Triage in Compensated WIP via automation Mar 26, 2020
@zspencer zspencer moved this from To Triage to In Progress in Compensated WIP Mar 26, 2020
@zspencer zspencer mentioned this issue Mar 27, 2020
Merged
@drllau
Copy link
Contributor

drllau commented Mar 27, 2020

@zspencer , my laptop power supply just carked it so I'll be offline maybe weekend (or longer) to transfer my HD so get back to this next week.

@zspencer
Copy link
Member

No worries! Stay safe!

zspencer added a commit that referenced this issue May 4, 2020
@zspencer
📝 Replace contributing with backlink to core Contributing guide
1fa8763 
This makes it a bit easier to keep the contributing guide up to date
in one place, and adds a "seam" to provide project-specific guidance.

See:
- #44
- zinc-collective/www.zinc.coop#14
@zspencer zspencer mentioned this issue May 4, 2020
Merged
@zspencer
Copy link
Member

zspencer commented May 4, 2020

@lanegrant - can you verify that these broken links are still a problem for you? Apologies for the delay I'm spinning about 5 plates too many ATM :); and strugglign to accept that my role isn't as much about driving feature work forward and is more about making it easier for people to contribute.

@ghost
Copy link
Author

ghost commented May 4, 2020

The broken links are fixed. Thank you

@zspencer zspencer closed this as completed May 4, 2020
Compensated WIP automation moved this from In Progress to Done May 4, 2020
zspencer added a commit that referenced this issue May 17, 2020
@zspencer
📝 Replace contributing with backlink to core Contributing guide (#64)
7b56ffc 
This makes it a bit easier to keep the contributing guide up to date
in one place, and adds a "seam" to provide project-specific guidance.

See:
- #44
- zinc-collective/www.zinc.coop#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zspencer zspencer

Labels
documentation Work that is intended to focus on improving documentation enhancement New feature or request
Projects
Compensated WIP
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zspencer @drllau