Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover the full-screen on iPhone XS Max and similar #7

Closed
3 tasks done
zspencer opened this issue May 5, 2020 · 1 comment
Closed
3 tasks done

Cover the full-screen on iPhone XS Max and similar #7

zspencer opened this issue May 5, 2020 · 1 comment
Assignees
@user512
Labels
bug Something isn't working code Hone your programming skills! design Hone your design skills!
Milestone
ShakeItPhoto 3.2.6

Comments

@zspencer
Copy link
Member

zspencer commented May 5, 2020 •
edited
Loading

In order to have a more pleasant usage experience
As a photographer with a modern iPhone
I would like the UI to scale to fill my device

This Issue May Be Closed When

  • The Interface no longer has gaps above and below the UI elements
  • A build is on TestFlight that has this fix applied
  • The release notes for the version it is included in include a line stating this bug is fixed.

296E26AE-1323-4FD2-965C-C17EA9D023BA_1_105_c
@zspencer zspencer added bug Something isn't working code Hone your programming skills! design Hone your design skills! labels May 5, 2020
@zspencer zspencer added this to the ShakeItPhoto 3.8.4 milestone May 5, 2020
@user512 user512 mentioned this issue May 11, 2020
Closed
@user512 user512 self-assigned this May 13, 2020
@user512 user512 mentioned this issue Jun 14, 2020
Merged
zspencer added a commit that referenced this issue Aug 10, 2020
@zspencer
Caught up release notes in preperation for 3.2.6
2a2ba00 
See:
- #9
- #7
- #3
@zspencer zspencer mentioned this issue Aug 10, 2020
Merged
zspencer added a commit that referenced this issue Aug 10, 2020
@zspencer
Caught up release notes in preperation for 3.2.6
80c165c 
See:
- #9
- #7
- #3
zspencer added a commit that referenced this issue Aug 10, 2020
@zspencer
Caught up release notes in preperation for 3.2.6
751070a 
See:
- #9
- #7
- #3
zspencer added a commit that referenced this issue Aug 10, 2020
@zspencer
Caught up release notes in preperation for 3.2.6
f954c8c 
See:
- #9
- #7
- #3

I've written out the "test" plan with the release notes; in the hopes
that when we release the next test-flight builds release notes and test
instructions we can copy-paste from the CHANGELOG.md file.

I also intend to link to this from the Community announcement.
user512 pushed a commit that referenced this issue Aug 14, 2020
@zspencer
Caught up release notes in preperation for 3.2.6 (#18)
c28bd87 
* Caught up release notes in preperation for 3.2.6

See:
- #9
- #7
- #3

I've written out the "test" plan with the release notes; in the hopes
that when we release the next test-flight builds release notes and test
instructions we can copy-paste from the CHANGELOG.md file.

I also intend to link to this from the Community announcement.

* Document how to become a tester
@zspencer
Copy link
Member Author

This has been deployed with 3.2.6! Thank you @theInternauts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@user512 user512

Labels
bug Something isn't working code Hone your programming skills! design Hone your design skills!
Projects
None yet
Milestone
ShakeItPhoto 3.2.6
Development

No branches or pull requests
2 participants
@zspencer @user512