Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apax nodes #81

Merged
merged 31 commits into from
May 3, 2023
Merged

Apax nodes #81

merged 31 commits into from
May 3, 2023

Conversation

Tetracarbonylnickel
Copy link
Contributor

This PR implements the apax model node, a performant apax JaxMD node, a bond stretch analyses and an uncertainty checker for the ASEMD node.

PythonFZ
PythonFZ requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to use it.
Looks good but I have some small comments that should be easy fixed

ipsuite/analysis/bond_stretch.py Outdated Show resolved Hide resolved
ipsuite/analysis/bond_stretch.py Outdated Show resolved Hide resolved
ipsuite/analysis/bond_stretch.py Outdated Show resolved Hide resolved
ipsuite/analysis/bond_stretch.py Show resolved Hide resolved
ipsuite/analysis/model/dynamics_checks.py Outdated Show resolved Hide resolved
tests/integration/calculators/md_minimal_apax.yaml Outdated Show resolved Hide resolved
tests/integration/calculators/test_apax_jaxmd.py Outdated Show resolved Hide resolved
tests/integration/test_i_apax.py Outdated Show resolved Hide resolved
tests/integration/test_i_apax.py Outdated Show resolved Hide resolved
tests/integration/test_i_apax.py Show resolved Hide resolved
@PythonFZ PythonFZ mentioned this pull request Apr 26, 2023
Closed
@PythonFZ PythonFZ mentioned this pull request Apr 28, 2023
Open
PythonFZ
PythonFZ approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work.

M-R-Schaefer
M-R-Schaefer requested changes May 2, 2023
View reviewed changes
Copy link
Contributor

@M-R-Schaefer M-R-Schaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the apax parts look good, There are some other sections where I left some comments.

@Tetracarbonylnickel Tetracarbonylnickel merged commit ef12234 into main May 3, 2023
@Tetracarbonylnickel Tetracarbonylnickel deleted the apax_nodes branch May 3, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PythonFZ PythonFZ PythonFZ approved these changes

@M-R-Schaefer M-R-Schaefer M-R-Schaefer approved these changes

Assignees

@M-R-Schaefer M-R-Schaefer

@PythonFZ PythonFZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tetracarbonylnickel @M-R-Schaefer @PythonFZ