Update Slicing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PythonFZ
commented
Feb 21, 2023
•
PythonFZ
commented
- add advanced slicing + tests
- fix permutation in advanced slicing
- add numpy intergation tests for advanced slicing
PythonFZ
commented
Feb 21, 2023
tests/test_utils.py
Outdated
Comment on lines
56
to
61
| assert znslice.utils.get_matched_indices( | ||
| selected=[0, 2], available=[[0, 1], [10, 11]], single_item=False | ||
| ) == [[0], [10]] | ||
| assert znslice.utils.get_matched_indices( | ||
| selected=[2, 0], available=[[0, 1], [10, 11]], single_item=False | ||
| ) == [[0], [10]] |
There was a problem hiding this comment.
The idea behind this prohibits unsorted gathering. It will return the indices per available so jumpy between the available data are not possible.
Possible Solutions
- Don't do relativ indices but absolut indices - i.e. remove
get_matched_indicesat all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.