Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix #830

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Hotfix #830

merged 5 commits into from
Mar 8, 2024

Conversation

AloeareV
Copy link
Contributor

@AloeareV AloeareV commented Mar 8, 2024

Fixes #826 (or at least, fixes the panic that we think is the cause of 826)

@AloeareV AloeareV changed the base branch from dev to stable March 8, 2024 18:54
zancas
zancas previously approved these changes Mar 8, 2024
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


 Summary [ 681.219s] 93 tests run: 92 passed (45 slow), 1 failed, 5 skipped
    FAIL [   2.658s] darkside-tests::network_interruption_tests interrupt_initial_tree_fetch

error: test run failed

@zancas
Copy link
Member

zancas commented Mar 8, 2024

Hmm.. I guess the previous fail was a flake...

cargo nextest run -p darkside-tests
   Compiling zingolib v0.2.0 (/home/nattyb/src/zingolabs/zingolibs/dev/zingolib)
   Compiling zingo-testutils v0.1.0 (/home/nattyb/src/zingolabs/zingolibs/dev/zingo-testutils)
   Compiling darkside-tests v0.1.0 (/home/nattyb/src/zingolabs/zingolibs/dev/darkside-tests)
    Finished test [optimized] target(s) in 38.93s
    Starting 14 tests across 5 binaries (2 skipped)
        PASS [   0.005s] darkside-tests constants::test::abandon_to_darkside_orch_10_000_000_zat
        PASS [   0.005s] darkside-tests constants::test::abandon_to_darkside_sap_10_000_000_zat
        PASS [   0.005s] darkside-tests::advanced_reorg_tests test_read_tree_state_from_file
        PASS [   0.006s] darkside-tests::advanced_reorg_tests test_read_block_dataset
        PASS [   2.356s] darkside-tests::network_interruption_tests interrupt_initial_tree_fetch
        PASS [   2.360s] darkside-tests::tests simple_sync
        PASS [   2.458s] darkside-tests::advanced_reorg_tests reorg_changes_incoming_tx_height
        PASS [   2.511s] darkside-tests::advanced_reorg_tests reorg_expires_incoming_tx
        PASS [   2.557s] darkside-tests::advanced_reorg_tests reorg_changes_incoming_tx_index
        PASS [   6.421s] darkside-tests::tests reorg_away_receipt
        PASS [   6.443s] darkside-tests::advanced_reorg_tests reorg_expires_outgoing_tx_height
        PASS [   6.902s] darkside-tests::advanced_reorg_tests reorg_changes_outgoing_tx_height
        PASS [   7.132s] darkside-tests::advanced_reorg_tests reorg_changes_outgoing_tx_index
        PASS [  13.426s] darkside-tests::tests sent_transaction_reorged_into_mempool
------------
     Summary [  13.429s] 14 tests run: 14 passed, 2 skipped

zancas
zancas previously approved these changes Mar 8, 2024
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The observed test fail, did not recur.

zancas
zancas previously approved these changes Mar 8, 2024
@zancas
Copy link
Member

zancas commented Mar 8, 2024

We don't yet have functional network-interrupt tests in CI. I have feature gated the test that was added to detect and fix this bug.

@zancas zancas marked this pull request as draft March 8, 2024 19:47
@zancas zancas marked this pull request as ready for review March 8, 2024 19:59
zancas
zancas previously approved these changes Mar 8, 2024
zancas
zancas previously approved these changes Mar 8, 2024
zancas
zancas previously approved these changes Mar 8, 2024
@fluidvanadium
Copy link
Contributor

why is it flaky?

@zancas
Copy link
Member

zancas commented Mar 8, 2024

Well, the feature gate didn't work with "cargo nextest run --archive-file", so I have reverted to ignore.

Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it proves the panic is fixed. i ran it 100 times locally with no failures.
great!

@fluidvanadium fluidvanadium merged commit 2113707 into zingolabs:stable Mar 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observed crash in IOS Xcode
3 participants