-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix #830
Hotfix #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary [ 681.219s] 93 tests run: 92 passed (45 slow), 1 failed, 5 skipped
FAIL [ 2.658s] darkside-tests::network_interruption_tests interrupt_initial_tree_fetch
error: test run failed
Hmm.. I guess the previous fail was a flake...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The observed test fail, did not recur.
We don't yet have functional network-interrupt tests in CI. I have feature gated the test that was added to detect and fix this bug. |
why is it flaky? |
Well, the feature gate didn't work with "cargo nextest run --archive-file", so I have reverted to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it proves the panic is fixed. i ran it 100 times locally with no failures.
great!
Fixes #826 (or at least, fixes the panic that we think is the cause of 826)