Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(zint): make ethers and wasm-opt optional #196

Merged
merged 7 commits into from
Dec 17, 2023
Merged

refactor(zint): make ethers and wasm-opt optional #196

merged 7 commits into from
Dec 17, 2023

Conversation

clearloop
Copy link
Member

@clearloop clearloop commented Dec 17, 2023 •
edited
Loading

Resolves #182
Resolves #181

Changes

  • make ethers optional
  • make wasm-opt optional
  • embed wasm-opt in zinkc

still can not get rid of wasm-opt, make it optional

@clearloop clearloop marked this pull request as ready for review December 17, 2023 21:33
@clearloop clearloop changed the title Make ethers and wasm-opt optional refactor(zinkc): make ethers and wasm-opt optional Dec 17, 2023
@clearloop clearloop changed the title refactor(zinkc): make ethers and wasm-opt optional refactor(zinkt): make ethers and wasm-opt optional Dec 17, 2023
@clearloop clearloop changed the title refactor(zinkt): make ethers and wasm-opt optional refactor(zint): make ethers and wasm-opt optional Dec 17, 2023
@clearloop clearloop merged commit 7498e29 into main Dec 17, 2023
4 checks passed
@clearloop clearloop deleted the cl/issue-182 branch December 17, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming ethers as optional dependency Consider removing wasm-opt as dependency
1 participant
@clearloop