Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PrimType#validate to accept ParserOptions #43

Closed
jdegoes opened this issue Nov 18, 2020 · 2 comments
Closed

Refactor PrimType#validate to accept ParserOptions #43

jdegoes opened this issue Nov 18, 2020 · 2 comments
Labels
zio-hackathon

Comments

@jdegoes
Copy link
Member

jdegoes commented Nov 18, 2020

Currently, ParserOptions are not threaded down into PrimType#validate, which means the primitive types cannot take advantage of any parser-specific settings. This could be useful, especially in the future. So we should refactor the validate method to take the parser options.
@FrancisToth
Copy link
Contributor

Hi, I want to give it a try slightly_smiling_face

@FrancisToth
Copy link
Contributor

PR here

@jdegoes jdegoes closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
zio-hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdegoes @FrancisToth