Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor List[HelpDoc] to HelpDoc #51

Closed
jdegoes opened this issue Nov 21, 2020 · 2 comments
Closed

Refactor List[HelpDoc] to HelpDoc #51

jdegoes opened this issue Nov 21, 2020 · 2 comments
Labels
zio-hackathon

Comments

@jdegoes
Copy link
Member

jdegoes commented Nov 21, 2020

There are places in the code that use List[HelpDoc]. However, two help docs can be combined into one using +. So this is not necessary. In fact, we can change all code that currently uses the type List[HelpDoc] into an ordinary HelpDoc.
@hollinwilkins
Copy link
Contributor

I wanna work on this one

@hollinwilkins
Copy link
Contributor

hollinwilkins commented Nov 21, 2020 •
edited
Loading

PR here: #53

Summary of Changes

  1. Find and replace all instances of List[HelpDoc] with HelpDoc
  2. Get rid of all cons operations in validate methods

@jdegoes jdegoes closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
zio-hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdegoes @hollinwilkins