-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question to the community] Removing jasync
modules?
#2881
Comments
I haven't been closely following the Scala world recently. However, my 2 cents: what about r2dbc support instead of jasync? r2dbc is a pretty mature API, it has some official drivers, and it also supports reactive streams. I'm not sure if the jdbc stream API matches the quality of r2dbc, but maybe with Loom support, it wouldn't matter anyway. Still, it'll work only on Java 21+. |
Our goal here is not to find a replacement for jasync |
@juliano I think we gave enough time to people to manifest themselves now. No one came here nor on Discord so I guess it's fair to consider that we can safely remove the JAsync support |
@guizmaii both PRs for quill and protoquill updated |
I gave a last chance to people on Twitter/Discord. Let's merge them tomorrow morning if no one manifested him/herself |
JAsync support as been dropped |
For what it's worth now, yes, we are using this. Even with a Obivously open source maintainers are free to drop whatever they want when they want to. But 3 weeks from "giving notice" by raising a GitHub issue to removing the feature is quite a short time. Nothing to do about it of course by now. |
Who's using the
jasync
modules?What if I tell you that I want to remove them?
Why did you make the choice to use the
jasync
backend over the JDBC one?I'm personally using Quill for several years, in different projects and companies and I've never used anything else than the JDBC backend, considering it a safer choice.
Why am I considering removing the
jasync
modules?Because there's a deadlock somewhere there. Either in the code or, if we're lucky, in the tests.
(But probably in the code, see https://x.com/lukasz_bialy/status/1707341633929314347?s=20)
We can clearly see the
jasync
CI deadlock sometimes (not that uncommon at all)Because maintaining Quill is already challenging, so I'm trying to remove as many things as possible to improve the life of the Quill maintainers.
This module feels like a duplicate of the JDBC one to me and apparently it has issues (deadlock in CI + issues reported by users)
If I understood correctly the talk of JDG at ZIO World 2023, the "blocking" JDBC way will be the one to prefer/the most performant one with Java 21 and virtual threads (See https://youtu.be/ygOmwze5ETk?si=r_GT4p4j_D6C0aHv)
The text was updated successfully, but these errors were encountered: