Skip to content
This repository has been archived by the owner on Jul 16, 2022. It is now read-only.

Delete ZMXServer Trait #113

Closed
adamgfraser opened this issue Nov 10, 2020 · 3 comments
Closed

Delete ZMXServer Trait #113

adamgfraser opened this issue Nov 10, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@adamgfraser
Copy link
Contributor

The ZMXServer trait currently only has a single method, close that closes the channel. We can delete this trait and have the ZMXServer.make operator return either a ZManaged or a ZLayer that builds in the necessary finalization logic.
@KadekM
Copy link
Contributor

KadekM commented Nov 20, 2020

I'd like to do this one for hackaton

@adamgfraser
Copy link
Contributor Author

@KadekM Great!

@KadekM KadekM mentioned this issue Nov 20, 2020
Merged
@softinio softinio added good first issue Good for newcomers and removed #ziohackathon labels Dec 28, 2020
@KadekM
Copy link
Contributor

KadekM commented Apr 1, 2021

@adamgfraser i think we can close this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@softinio @KadekM @adamgfraser