Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing core-tests and streams-tests #1561

Closed
5 tasks done
ghostdogpr opened this issue Sep 3, 2019 · 12 comments · Fixed by #1788
Closed
5 tasks done

Stop publishing core-tests and streams-tests #1561

ghostdogpr opened this issue Sep 3, 2019 · 12 comments · Fixed by #1788
Labels
build good first issue Good for newcomers help wanted Extra attention is needed tests

Comments

@ghostdogpr
Copy link
Member

ghostdogpr commented Sep 3, 2019

We want to stop publishing our tests, but we can't because they are currently used by the interop libraries.

Step 1:

Stop depending on core-tests in interop libraries. If it was actually used, replace it with ZIO Test.

(cats and reactive-streams are already not using it)

Example of using ZIO Test here: https://zio.dev/docs/usecases/usecases_testing

Step 2:

Stop publishing core-tests and streams-tests

@ghostdogpr ghostdogpr added help wanted Extra attention is needed good first issue Good for newcomers build tests labels Sep 3, 2019
@vilu
Copy link
Contributor

vilu commented Sep 4, 2019

I would like to tackle this one.

@ghostdogpr
Copy link
Member Author

@vilu Thanks! Let us know if you need any help.

@ghostdogpr
Copy link
Member Author

@vilu which interop are you tackling first? I ask in case other contributors want to share the work.

@vilu
Copy link
Contributor

vilu commented Sep 6, 2019

I work from the top to the bottom. I'll post a PR to the Twitter one this weekend to get a confirmation that I'm addressing it in the right way.

I can keep updating this PR when I pick a new one. So, just to re-iterate I'm currently working on the Twitter one. Any other one would be ok for anyone to pick up without us stepping on each others toes.

@ghostdogpr
Copy link
Member Author

@vilu sounds good 👌

@mijicd
Copy link
Member

mijicd commented Sep 6, 2019

@vilu just link this issue in your PRs and feel free to reach out if you need any help.

@vilu
Copy link
Contributor

vilu commented Sep 8, 2019

I actually ran into some issues: zio/interop-twitter#29 would love some feedback here.

@ghostdogpr
Copy link
Member Author

Working on interop-java

@ghostdogpr
Copy link
Member Author

Monix and Java done

@sideeffffect
Copy link
Member

will do guava

@sideeffffect
Copy link
Member

guava done zio/interop-guava#3

@ghostdogpr
Copy link
Member Author

Step 1 completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build good first issue Good for newcomers help wanted Extra attention is needed tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants