Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonEmptyChunk is not serializable #7706

Closed
ncreep2 opened this issue Jan 15, 2023 · 2 comments · Fixed by #7707
Closed

NonEmptyChunk is not serializable #7706

ncreep2 opened this issue Jan 15, 2023 · 2 comments · Fixed by #7707
Assignees
@adamgfraser
Labels
bug Something isn't working

Comments

@ncreep2
Copy link

ncreep2 commented Jan 15, 2023

Hi,

I accidentally stumbled on the fact that NonEmptyChunk is not marked a serializable.

Is that on purpose?
Assuming that we enforce non-emptiness on deserialization, any reason why NonEmptyChunk can't implement Serializable?

Thanks
@adamgfraser
Copy link
Contributor

Thanks for reporting! Will take a look!

@adamgfraser adamgfraser self-assigned this Jan 15, 2023
@adamgfraser adamgfraser added the bug Something isn't working label Jan 15, 2023
@adamgfraser adamgfraser mentioned this issue Jan 16, 2023
Merged
@ncreep2
Copy link
Author

ncreep2 commented Jan 16, 2023

@adamgfraser, great, thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamgfraser adamgfraser

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make NonEmptyChunk Serializable
2 participants
@ncreep2 @adamgfraser