use cfg-if! macro to clarify conditional compilation sections #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pr0methean the first two commits are from #125 so this can compile correctly, I will remove them once that is merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
As I see it, this doesn't improve readability at all, just adds more lines and an extra level of nesting -- an unacceptable price to pay IMO for de-duplicating between |
|
Managed to eliminate a few |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #125 (comment), the
cfg-ifcrate can be helpful for complex conditional compilation (like that introduced in #125). I believe I had made this change in the previous zip repo, but hadn't pushed it. This should produce no change in compiled output compared to the previous#[cfg(...)] { ... }blocks.