fix: Decode Zip-Info UTF8 name and comment fields (#159) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pr0methean
added
the
waiting to be automatically merged
…requirement into the trait name
Pr0methean
removed
the
waiting to be automatically merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per APPNOTE 4.6.8 and 4.6.9, some ZIP archives have romanized filenames and comment text in CP437 for backward compatibility, but also have an extra data field containing the name in its own writing system in UTF-8. In such cases, we now extract the filename and comment from their respective extra fields. Fixes #159(?).