Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger before_trading_start() on a mid-day start #54

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Trigger before_trading_start() on a mid-day start #54

merged 1 commit into from
Aug 29, 2017

Conversation

tibkiss
Copy link

@tibkiss tibkiss commented Aug 28, 2017

No description provided.

@tibkiss
Copy link
Author

tibkiss commented Aug 28, 2017

Fix the problem that before_trading_start() is only called if the algo was running at 8:45 EDT
(before_trading_start_minutes).

@coveralls
Copy link

coveralls commented Aug 28, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.028% when pulling f3ce2ad on tibkiss:before_trading_start_trigger into 09672d4 on zipline-live:master.

pbharrin
pbharrin approved these changes Aug 29, 2017
View reviewed changes
Copy link

@pbharrin pbharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good,

@tibkiss
Copy link
Author

tibkiss commented Aug 29, 2017

Rebased on top of master, ready to merge.

@tibkiss tibkiss merged commit 6f5e353 into zipline-live:master Aug 29, 2017
@tibkiss tibkiss deleted the before_trading_start_trigger branch August 29, 2017 18:48
@coveralls
Copy link

coveralls commented Aug 29, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.057% when pulling ddbdf86 on tibkiss:before_trading_start_trigger into 816e8cf on zipline-live:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbharrin pbharrin pbharrin approved these changes

@bartosh bartosh Awaiting requested review from bartosh

@fredfortier fredfortier Awaiting requested review from fredfortier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tibkiss @coveralls @pbharrin