Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine historical with realtime collected bars #62

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Combine historical with realtime collected bars #62

merged 1 commit into from
Oct 1, 2017

Conversation

tibkiss
Copy link

@tibkiss tibkiss commented Sep 30, 2017

data.history() now returns ingested data combined with realtime data collected from broker.

@coveralls
Copy link

coveralls commented Sep 30, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 86.173% when pulling 3b5745e on tibkiss:feature/combine_historical_with_realtime_bars into 7d1e8b1 on zipline-live:master.

bartosh
bartosh approved these changes Oct 1, 2017
View reviewed changes
Copy link

@bartosh bartosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pbharrin
pbharrin approved these changes Oct 1, 2017
View reviewed changes
Copy link

@pbharrin pbharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tibkiss tibkiss merged commit 094018e into zipline-live:master Oct 1, 2017
@tibkiss tibkiss deleted the feature/combine_historical_with_realtime_bars branch October 1, 2017 14:22
@tibkiss tibkiss mentioned this pull request Oct 8, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbharrin pbharrin pbharrin approved these changes

@bartosh bartosh bartosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tibkiss @coveralls @bartosh @pbharrin