Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP basic authentication header detection for cURL example #110

Merged
merged 1 commit into from
Jan 21, 2014
Merged

Fix HTTP basic authentication header detection for cURL example #110

merged 1 commit into from
Jan 21, 2014

Conversation

jandillmann
Copy link
Contributor

Unfortunately there is a bug in my previous pull request #108.

Headers in specs are written with a HTTP_ prefix (e.g. HTTP_AUTHORIZATION), and given without alteration to the Curl class (source).

When generating the API documentation, headers for Curl are set by ClientBase (source), which includes Headers which formats them nicely (e.g. "Authorization") (source).

Therefore the spec is green, but the generated documentation does not show the username and password as desired. This pull request changes one line to use a regular expression to detect the authorization header, either written as HTTP_AUTHORIZATION or Authorization.

@oestrich
Copy link
Contributor

I probably should have caught that. Thanks for checking up on this.

oestrich added a commit that referenced this pull request Jan 21, 2014
Fix HTTP basic authentication header detection for cURL example
@oestrich oestrich merged commit 44be914 into zipmark:master Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants