Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for do_request and extra parameters containing path params and query string params #53

Merged
merged 2 commits into from
Sep 29, 2012

Conversation

denyago
Copy link
Contributor

@denyago denyago commented Sep 25, 2012

When dealing with path like /items_a/:items_a_id/items_b/:id and using do_request with :items_a_id, :id and :an_extra_param, do_request calls path 2 times:

  • first to set path_or_query,
  • second to set path in case of :get method.

But call to path, deletes :items_a_id and :id from extra_params hash. So at the end, path is equal to /items_a/:items_a_id/items_b/:id?an_extra_param=

@samwgoldman
Copy link
Contributor

Looks good to me. @oestrich?

samwgoldman added a commit that referenced this pull request Sep 29, 2012
Fix for do_request and extra parameters containing path params and query string params
@samwgoldman samwgoldman merged commit 5293fe9 into zipmark:master Sep 29, 2012
@samwgoldman
Copy link
Contributor

Thanks @denyago!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants