Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callbacks parameter to OperationTrait #1196

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

edipoReboucas
Copy link
Contributor

@edipoReboucas edipoReboucas commented Apr 10, 2022

"callbacks" parameter is missing on OperationTrait constructor.

I implemented this bugfix based on PR #1191.

Copy link
Collaborator

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits but otherwise looking good.
Very happy about the updated tests :)

src/Attributes/OperationTrait.php Outdated Show resolved Hide resolved
tests/Analysers/ReflectionAnalyserTest.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks.

@DerManoMann DerManoMann merged commit b327c9c into zircote:master Apr 11, 2022
@DerManoMann
Copy link
Collaborator

Thanks @edipoReboucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants