Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minProperties/maxProperties to attributes #1376

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

DerManoMann
Copy link
Collaborator

Fixes #1373

@DerManoMann DerManoMann merged commit 5f56550 into zircote:master Jan 3, 2023
@DerManoMann DerManoMann deleted the min-max-properties branch January 3, 2023 20:37
@jdecool
Copy link

jdecool commented Jan 5, 2023

This PR has been tagged as a bug fix (https://github.com/zircote/swagger-php/releases/tag/4.5.4).

But it potentially introduces a BC break in applications as the constructor definition as changed, and new fields are optionals but they are introduced in the middle of other parameters, no ?

@DerManoMann
Copy link
Collaborator Author

Good point. I've never considered that, mostly because I've never used attributes without using named parameters.

The main reason for the order I inserted them was to keep them the same as they are defined in the annotations.

@jdecool
Copy link

jdecool commented Jan 6, 2023

I've never considered that, mostly because I've never used attributes without using named parameters.

Neither me.

But I've noticed that on one project I'm currently working on

@DerManoMann
Copy link
Collaborator Author

Apologies. I hope we'll do better next time.

I did add a note to the release notes, but for practical purposes that is mostly cosmetic I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Unknown named property "minProperties"
2 participants