Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): check if getTokenIDAndClaims succeeded #429

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

muhlemmer
Copy link
Collaborator

When getTokenIDAndClaims didn't succeed,
so ok would be false.
This was ignored and the accessTokenClaims.Claims call would panic.

Closes #316

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

When getTokenIDAndClaims didn't succeed,
so `ok` would be false.
This was ignored and the accessTokenClaims.Claims call would panic.
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #429 (645aa19) into main (45582b6) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   52.69%   52.68%   -0.02%     
==========================================
  Files          74       74              
  Lines        5725     5727       +2     
==========================================
  Hits         3017     3017              
- Misses       2446     2447       +1     
- Partials      262      263       +1     
Files Changed Coverage Δ
pkg/op/token_exchange.go 51.29% <0.00%> (-0.45%) ⬇️

@muhlemmer muhlemmer merged commit 4ed2699 into main Aug 18, 2023
6 of 8 checks passed
@muhlemmer muhlemmer deleted the fix-tokenexchange-panic branch August 18, 2023 15:54
@github-actions
Copy link

🎉 This PR is included in version 2.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getTokenIDAndClaims should return an error
2 participants