Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default values for applications #32

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: default values for applications #32

merged 1 commit into from
Nov 10, 2022

Conversation

stebenz
Copy link
Contributor

@stebenz stebenz commented Nov 8, 2022

closes #25

@stebenz stebenz self-assigned this Nov 8, 2022
eliobischof
eliobischof reviewed Nov 9, 2022
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all enums have a default? What about e.g. the action trigger type and others?

@stebenz
Copy link
Contributor Author

stebenz commented Nov 9, 2022

Should all enums have a default? What about e.g. the action trigger type and others?

No, defaults on terraform provider side are only used if ZITADEL would set a default value if nothing is provided, as explained here.

@stebenz stebenz merged commit 6d748cd into alpha Nov 10, 2022
@hifabienne hifabienne deleted the alpha-default-values-fix branch May 25, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof approved these changes

Assignees

@stebenz stebenz

Labels
fix infra lang: go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stebenz @eliobischof