Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multifactor Authentication #65

Merged
merged 49 commits into from
May 8, 2024
Merged

Multifactor Authentication #65

merged 49 commits into from
May 8, 2024

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Apr 16, 2024

This PR adds MFA support to the login

Closes #18
Closes #15

if user has mfa:

  • TOTP check /otp/time-based
  • U2F check /u2f
  • OTP SMS check /otp/sms
  • OTP Email check /otp/email

if user has no mfa setup and login settings includes second factors:

  • Choose which factor to setup /mfa/set
  • Setup MFA page /mfa/set
    • Enable OTP SMS
    • Enable OTP Email
  • Setup TOTP Page (QR code, url) /otp/time-based/set
  • Setup U2F Page /u2f/set

if user has multiple factors

  • Choose factor to verify /mfa

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Jest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:04pm

@peintnermax peintnermax merged commit cd1cbe4 into main May 8, 2024
5 checks passed
@peintnermax peintnermax deleted the qa branch May 8, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Login: Login with MFA Login: Register MFA
2 participants