Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move app code into src dir #68

Merged
merged 1 commit into from
May 15, 2024

Conversation

yordis
Copy link
Contributor

@yordis yordis commented May 13, 2024

Context

  • Added @zitadel/prettier-config so that the Prettier configuration is deterministic

  • Upgraded the CI to Node 20x, which is the LTS version, 20x has been stable for a while by now.

  • Ran Prettier formatter

  • Fixed ESLint rules

  • Move app into src. Isolates the codebase related to the actual source code so that everything is under src so that other directories like Cypress, mock, and anything in the future do not add much noise.

  • Change #/ to @/. Honestly, I had never seen #/ being used before. Most of the React ecosystem is used to see @/ as the alias (as well as Vue).

Links

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Jest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented May 13, 2024

@yordis is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

@yordis yordis force-pushed the chore-app-dir-org branch 4 times, most recently from 6078ce8 to a1dfeda Compare May 13, 2024 20:40
@yordis
Copy link
Contributor Author

yordis commented May 13, 2024

I have no idea how other PRs and main branch CI is passing when I had to fix some lint issues 🤷🏻

@yordis yordis force-pushed the chore-app-dir-org branch 4 times, most recently from d5b0704 to 84aaf72 Compare May 13, 2024 20:59
@yordis
Copy link
Contributor Author

yordis commented May 14, 2024

@peintnermax do you mind sharing your thoughts here? 🙏🏻

@peintnermax
Copy link
Member

Its a nice proposal. I fully agree on your arguments and am fine with the changes 👍

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 6:51am

@peintnermax peintnermax merged commit b1473fe into zitadel:main May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants