Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve tsconfigs and deps #69

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

yordis
Copy link
Contributor

@yordis yordis commented May 16, 2024

Context

  • Improve the tsconfigs to use Node LTS and create one for tsup for more straightforward understanding of which one to use
  • Replaced jest with test; looking ahead, the story of jest and ESM isn't good even four years later. Even the jest people acknowledge that making it work is difficult due to the legacy architecture. By now, vitest is everywhere, even in the React ecosystem for green-field projects. It simplifies the deps management, provides first-class support for ESM, and has most if not all features from jest
  • Upgraded some package dependencies, primarily around developer tools
  • Moved some of the devtools dependencies to the root
  • Improved tsup set up

Copy link

vercel bot commented May 16, 2024

@yordis is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@yordis yordis changed the title chore: improve tsconfigs chore: improve tsconfigs and deps May 16, 2024
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 7:40am

@peintnermax
Copy link
Member

Nice thx for the PR.. love the change to vitest, it clears deps up a lot..
When I run the PR though it breaks the UI. Did not get what might be causing it yet ..
Screenshot 2024-05-16 at 13 55 59

@yordis
Copy link
Contributor Author

yordis commented May 16, 2024

CSS issue was solved, but the tailwind setup was broken ...

@peintnermax peintnermax merged commit 6c275bb into zitadel:main May 17, 2024
5 checks passed
@yordis yordis deleted the chore-tsconfig branch May 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants