Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no results appeared ! #7

Closed
trungpham2606 opened this issue Apr 16, 2021 · 3 comments
Closed

no results appeared ! #7

trungpham2606 opened this issue Apr 16, 2021 · 3 comments

Comments

@trungpham2606
Copy link

trungpham2606 commented Apr 16, 2021

Dear @JiamingSuen
Thank you for sharing such a great work !
I was testing random pair of images and this is the result I got:
image

I'm wondering that maybe LoFTR is suffering the same problem as SuperGlue that it cant detect matching when the image is rotated more than 45 degree ?
I was using the indoor_ds weights.

@zehongs
Copy link
Member

zehongs commented Apr 16, 2021

Hi, I believe the reason is that we didn't train LoFTR with pairs that exhibit extreme rotation. We only downsampled the image pairs from MegaDepth and ScanNet, and the purpose of which was to reduce GPU memory.
By the way, for matching pairs with extreme rotation and scaling, you can refer to our Neurips'19 work GIFT.

@JiamingSuen
Copy link
Member

JiamingSuen commented Apr 16, 2021

Hi, I believe the reason is that we didn't train LoFTR with pairs that exhibit extreme rotation. We only downsampled the image pairs from MegaDepth and ScanNet, and the purpose of which was to reduce GPU memory.
By the way, for matching pairs with extreme rotation and scaling, you can refer to our Neurips'19 work GIFT.

In addition to Zehong's reply, I would like to point out that LoFTR (and SuperGlue) learns the matching priors (i.e., the distribution of matches between the image pair) from the training data, which means that it can only handle rotations exhibited in the training set. In most real-world scenarios like in ScanNet and MegaDepth, there won't be many extreme rotation variations like the image pair given (over 90 degrees). With that being said, handling extreme rotation changes is indeed another interesting research topic beyond the major focus of LoFTR. We recommend you to check out our work GIFT and more recent work LISRD for this purpose.

@trungpham2606
Copy link
Author

trungpham2606 commented Apr 16, 2021

Thank @JiamingSuen @zehongs for your quick and detailed response. I'm gonna have a look at GIFT and LISRD.
I have checked GIFT, it outperformed Superpoint all the cases I tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants