Various patches #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not clear that this is the right fix, but unbreaks the build for me.
strlen() + strcpy() is silly.
Previously assigned to the wrong union member -- not super likely to cause a problem, but illegal per C99 strict aliasing.
If #close() was invoked, zookeeper_close() might be invoked again by the Ruby GC, leading to a double free(). The previous coding also neglected to call zookeeper_close() on a non-connected ZK handle, which would leak resources.
This patch fixes a per-connection memory leak: the previous coding allocated a zkrb_calling_context for each ZK handle but neglected to free it. This patch also raises a Ruby exception if any operations on performed on a closed ZK handle, until #reopen() is called. Such operations would just segfault anyway.
ZK allows a path to be created that has no associated data. In the previous coding, doing a #get() on such a path would result in raising a Ruby exception: zoo_get() returns data_len == -1 for the path, which isn't a legal string length.
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for memory leaks, compiler warnings, double free(), a minor bug in #get(), and unbreaks the build for OSX 10.6 (the last is maybe not the best way to do it, but works-for-me).