Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double spending tx are considered replacement #12301

Merged
merged 2 commits into from Mar 13, 2024

Conversation

lontivero
Copy link
Collaborator

After this PR the unconfirmed double spending transactions are considered replacements. Latest seen transactions are considered replacements for those already known independently of the fees.

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will the coordinator react if I send a tx with the coin that was coming from the replacement tx. Or if I try to register the coin to the CJ?

@lontivero
Copy link
Collaborator Author

The backend is the broadcating fallback mechanism, not the main one. It will accept or reject the transaction depending on how it is configured.
This PR contains something that needs to be done before we switch to Full-RBF.

@molnard
Copy link
Collaborator

molnard commented Feb 6, 2024

The backend is the broadcating fallback mechanism, not the main one.

I see, so this will break the fallback mechanism in some cases. It is not good.

accept or reject the transaction depending on how it is configured.

How is it configured?

we switch to Full-RBF

Do we go for it? That project needs to be prepared and well considered when everything is ready, switch on both client and backend side. Otherwise the backend and client or vice versa won't be on the same page and we will have a lot of issues.

It would be good to have a meeting about this first.

Copy link
Collaborator

@molnard molnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK we agreed on the meeting this is a safe change.

@molnard molnard merged commit 92e4921 into zkSNACKs:master Mar 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants