Upstream bevy system changes #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosingrind
commented
Apr 20, 2023
| @@ -264,7 +271,7 @@ impl Plugin for BigBrainPlugin { | |||
|
|
|||
| /// [`BigBrainPlugin`] system sets. Use these to schedule your own | |||
| /// actions/scorers/etc. | |||
| #[derive(Clone, Debug, Hash, Eq, PartialEq, SystemSet, Reflect)] | |||
| #[derive(Clone, Debug, PartialEq, Eq, Hash, SystemSet, Reflect)] | |||
There was a problem hiding this comment.
ScheduleLabel may be a good fit here as it's used in main_schedule.rs, but I didn't see a proper way to utilize it
|
Seems like there won't be any sufficient changes, closing this as the PR won't provide any value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims to fix problems introduced by bevyengine/bevy#8079. I'm working with
bevy/mainbranch and overall it's an only issue I've had, but I think more may be introduced in upcoming changes until0.11release, so I'm marking these changes as a draft