fixes bug in ls where old index entries come back #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
Feb 3, 2023
zkat
pushed a commit
that referenced
this pull request
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a bug where old entries stay in the
lslisting. We're using it to count the size of the cache so we can truncate it to a max size. The deletion of both content and index entry works fine but the ls command does not reflect it.It seems to go wrong during the conversion of the
Vec<SerializableMetadata>frombuck_entriesthat get's converted to aHashSet<SerializableMetadata>where each entry after the first is not written into the map so you only get back the first entry of the index file. If you reverse the vec it goes fine. I've included a bug fix and regression test.Thanks for this crate and your time on this!