This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a rough sketch of keeping size information in the cache index. Even though we already verify size if it's passed in, this can make error reporting a little nicer, as well as improve on the sorts of things
verify()
can do (and report!).Having size information is super handy for being able to determine whether to, say, load the entire contents of something into memory vs using streams, figuring out whether to memoize them, etc. Both make-fetch-happen and cacache itself are able to take advantage of this.
This bumps the index version to 5, too, but as usual, that's not a breaking change.
I mentioned before that this could help with SHAttered, but I didn't realize both of them were the exact same size :< -- there's a separate mitigation for that to prevent it from affecting the cache if both are inserted.